Re: [PATCH v7 11/12] soc: qcom: add core driver for the Qualcomm Crypto Engine

[Uwe Kleine-König]

Hello Bart,

On Thu, Sep 10, 2026 at 03:00:52PM +0200, Bartosz Golaszewski wrote:
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>

Please don't add new includes for <linux/mod_devicetable.h>. Either rely
on <linux/platform_device.h> to provide of_device_id (my preference), or
include <linux/device-id/of.h>.

> [...]
> +static const struct of_device_id qce_core_of_match[] = {
> +	{ .compatible = "qcom,crypto-v5.1", },
> +	{ .compatible = "qcom,crypto-v5.4", },
> +	{ .compatible = "qcom,qce", },
> +	{}

Please drop the commas for before the closing }. Also in my cleanups
around these device_id structs I used { } with a space in-between the
braces. Just today I got some opposition to that[1], but in combination
with the spacing in the non-empty initializers I still prefer { } over
{}.

> +};
> +MODULE_DEVICE_TABLE(of, qce_core_of_match);

Best regards
Uwe

[1] https://lore.kernel.org/all/45a04396-c6c1-41f4-ace8-0ee0ccbc50ad@xxxxxxx/

Attachment: signature.asc
Description: PGP signature