Re: [PATCH v4 3/3] i3c: add i3cdev module to expose i3c dev in /dev

From: Adrian Hunter

Date: Fri Sep 11 2026 - 15:10:53 EST


On 11/09/2026 06:44, Sam Agazaryan wrote:
> On Wed Sep 9, 2026 at 9:51 PM UTC, Frank Li wrote:
>> On Sun, Sep 06, 2026 at 08:27:47PM +0000, Sam Agazaryan wrote:
>>> From: Vitor Soares <vitor.soares@xxxxxxxxxxx>
>>> + for (i = 0; i < nxfers; i++) {
>>> + if (xfers[i].rnw) {
>>> + if (copy_to_user(u64_to_user_ptr(xfers[i].data),
>>> + data_ptrs[i], xfers[i].len))
>>
>> Use actual_len,
>
> Updated in v5.

actual_len is a problem. Only 2 controller drivers support it.
No I3C device drivers support it. mctp-i3c reads len not actual_len.
regmap-i3c ignores len and actual_len. And its definition comment
is not exactly correct since it is only valid for reads.

Despite that, the additional issue here, is what to do about a short
read. Seems like it should be in the uapi, but actual_len needs to
be fixed first.