Re: [PATCH v11 02/23] x86/resctrl: Check if monitoring features are enabled

[Reinette Chatre]

Hi Tony,

On 9/11/26 12:11 PM, Luck, Tony wrote:
> On Wed, Sep 09, 2026 at 08:52:39PM -0700, Reinette Chatre wrote:
>> On 8/31/26 10:44 AM, Tony Luck wrote:

...

>>> +	/* Any monitoring at all? */
>>> +	if (!cpu_feature_enabled(X86_FEATURE_RDT_M))
>>
>> Previous patch aimed for "symmetry with X86_FEATURE_RDT_A" ... but the "symmetrical"
>> code in get_rdt_alloc_resources() is:
>>
>> 	if (!boot_cpu_has(X86_FEATURE_RDT_A))
>> 		return false;
> 
> I've dropped the #define name change, so the symmetry goal is now moot.
> I still plan to use cpu_feature_enabled() based on the block comment in
> arch/x86/include/asm/cpufeature.h saying that cpu_feature_enabled() is:
> 
> 	"the default CPU features testing macro to use in code"

Thank you for pointing that out. Looking at the history of that line it seems to
originate from one of Boris's patch checking scripts so would surely be required
when requesting its inclusion:

	https://lore.kernel.org/all/20241025155830.GQZxvAJkJnfLfNpSRx@fat_crate.local/

I was not aware of these patch checking scripts. This looks to be something I need to
start running myself. 

Reinette