Re: [PATCH v2 4/4] clk: meson: t7: don't mark sys_ampipe_nand as critical
From: Brian Masney
Date: Fri Sep 11 2026 - 20:10:49 EST
Hi Lucas,
On Sat, Sep 05, 2026 at 04:32:34PM +0100, Lucas Tanure wrote:
> sys_ampipe_nand clocks the pipeline stage inserted in the bus path
> between the SD/eMMC controllers and the NIC_MATRIX fabric. It does have
> identifiable consumers - the three MMC controllers - so marking it
> critical was the wrong tool: the clock should be referenced from the
> consumer nodes and claimed by the mmc driver instead.
>
> Drop the CLK_IS_CRITICAL flag and update the comment accordingly.
> sys_am2axi0..2 remain critical as they clock the AXI DMA bus itself and
> have no single identifiable consumer.
>
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx>
> ---
> This patch depends on the MMC controllers actually referencing the clock:
> the dt-bindings, mmc driver and t7 DTS changes adding the "pipeline"
> clock must land before this patch, otherwise the boot hangs and memory
> corruption this clock caused are reintroduced.
This series should be merged together in one tree? Which tree? I can
provide an Acked-by if it should go through the mmc tree.
Brian