Re: [PATCH v1 00/10] ACPI: thermal: Register thermal class cooling devices under parents

From: Rafael J. Wysocki (Intel)

Date: Sat Sep 12 2026 - 09:36:20 EST


On Fri, Sep 11, 2026 at 11:35 PM Armin Wolf <W_Armin@xxxxxx> wrote:
>
> Am 11.09.26 um 15:00 schrieb Rafael J. Wysocki:
>
> > Hi All,
> >
> > This series generally changes the way in which thermal class cooling devices
> > are used by ACPI device drivers registering them (ACPI processor, ACPI fan,
> > and ACPI video) and by the ACPI thermal zone device driver.
> >
> > First, it causes the thermal class cooling devices to be registered under
> > parents in specific locations within the device hierarchy which allows
> > their relationships with other devices to be recognized more easily. It
> > also drops custom sysfs attributes registered by the users of the thermal
> > class cooling devices because they are not particularly useful any more
> > when those devices get proper parents.
> >
> > Second, it modifies the ACPI thermal zone device driver to use thermal class
> > cooling device parent information for binding cooling devices to trip points
> > in thermal zones, which was previously done with the help of the devdata
> > pointers of the cooling devices and effectively prevented drivers from using
> > the devdata pointers for their own purposes as originally intended.
> >
> > Finally, it updates the ACPI processor and ACPI fan drivers to use the
> > devdata pointers of thermal class cooling devices in a bit more efficient
> > way.
> >
> > The first two patches in the series are preliminary fixes preventing
> > Sashiko from reporting "pre-existing issues" in the subsequent patches.
> >
> > The third patch is a thermal core update allowing thermal class cooling
> > devices to be registered under proper parents.
> >
> > The other patches update the ACPI processor, ACPI video, and ACPI fan
> > drivers as per the above.
> >
> > The details are covered by individual patch changelogs.
> >
> > Thanks!
>
> Nice patch series, it looks mostly good to me.

Thanks!

> Do you plan something similar for thermal zones?

I do overall, but that is a bit harder due to the hwmon involvement.