Re: [PATCH] media: v4l2-subdev: Fix media_entity_operations references in kernel-doc

From: Laurent Pinchart

Date: Sat Sep 12 2026 - 12:36:19 EST


On Sat, Sep 12, 2026 at 07:58:50AM +0200, Karl Mehltretter wrote:
> The kernel-doc comment of v4l2_subdev_link_validate() refers to
> media_entity_ops, which does not exist. The name is
> media_entity_operations. Say media_entity_operations.
>
> Fixes: 5fd3e2412ade ("media: v4l2-subdev: Support hybrid links in v4l2_subdev_link_validate()")
> Assisted-by: LLM

Throwing LLMs at this kind of things is neither a good use of computing
resources nor a good use of maintainer time. Please refrain from doing
so in the future.

> Signed-off-by: Karl Mehltretter <kmehltretter@xxxxxxxxx>
> ---
> include/media/v4l2-subdev.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index d256b7ec8f848c51416cd1b62ff931ddc4feb4fd..6c4a0a6334e8e210c5da48527c1ad514568bd633 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -1236,10 +1236,10 @@ int v4l2_subdev_link_validate_default(struct v4l2_subdev *sd,
> * width, height and the media bus pixel code are equal on both
> * source and sink of the link.
> *
> - * The function can be used as a drop-in &media_entity_ops.link_validate
> + * The function can be used as a drop-in &media_entity_operations.link_validate
> * implementation for v4l2_subdev instances. It supports all links between
> * subdevs, as well as links between subdevs and video devices, provided that
> - * the video devices also implement their &media_entity_ops.link_validate
> + * the video devices also implement their &media_entity_operations.link_validate
> * operation.
> */
> int v4l2_subdev_link_validate(struct media_link *link);

--
Regards,

Laurent Pinchart