[PATCH v1 03/11] leds: st1202: Name pattern index variables consistently

From: Manuel Fombuena

Date: Sat Sep 12 2026 - 18:33:58 EST


The driver already names pattern indices "pattern" in the signatures of
st1202_pwm_pattern_write() and st1202_duration_pattern_write(), and
st1202_blink_set() follows the same convention. The remaining loops
abbreviate it to "patt", which matches nothing else in the file.

Rename those loop variables to "pattern". In st1202_led_pattern_set()
that name is taken by the array of pattern steps, so rename the
parameter to "patterns", which also reflects better that it is an array.

Two st1202_pwm_pattern_write() calls exceed 100 columns with the longer
name and are wrapped accordingly.

No functional change.

Signed-off-by: Manuel Fombuena <fombuena@xxxxxxxxxxx>
Assisted-by: LLM
---
drivers/leds/leds-st1202.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c
index d8a04e96fb46..ddb8c6027706 100644
--- a/drivers/leds/leds-st1202.c
+++ b/drivers/leds/leds-st1202.c
@@ -177,8 +177,8 @@ static void st1202_brightness_set(struct led_classdev *led_cdev,

guard(mutex)(&chip->lock);

- for (int patt = 0; patt < ST1202_MAX_PATTERNS; patt++)
- st1202_pwm_pattern_write(chip, led->led_num, patt, ST1202_PATTERN_PWM_FULL);
+ for (int pattern = 0; pattern < ST1202_MAX_PATTERNS; pattern++)
+ st1202_pwm_pattern_write(chip, led->led_num, pattern, ST1202_PATTERN_PWM_FULL);
st1202_write_reg(chip, ST1202_ILED_REG0 + led->led_num, value);
__st1202_channel_set(chip, led->led_num, !!value);
}
@@ -215,12 +215,13 @@ static int st1202_led_pattern_clear(struct led_classdev *ldev)
if (ret != 0)
return ret;

- for (int patt = 0; patt < ST1202_MAX_PATTERNS; patt++) {
- ret = st1202_pwm_pattern_write(chip, led->led_num, patt, ST1202_PATTERN_PWM_FULL);
+ for (int pattern = 0; pattern < ST1202_MAX_PATTERNS; pattern++) {
+ ret = st1202_pwm_pattern_write(chip, led->led_num, pattern,
+ ST1202_PATTERN_PWM_FULL);
if (ret != 0)
return ret;

- ret = st1202_write_reg(chip, ST1202_PATTERN_DUR + patt, 0);
+ ret = st1202_write_reg(chip, ST1202_PATTERN_DUR + pattern, 0);
if (ret != 0)
return ret;
}
@@ -229,7 +230,7 @@ static int st1202_led_pattern_clear(struct led_classdev *ldev)
}

static int st1202_led_pattern_set(struct led_classdev *ldev,
- struct led_pattern *pattern,
+ struct led_pattern *patterns,
u32 len, int repeat)
{
struct st1202_led *led = cdev_to_st1202_led(ldev);
@@ -239,9 +240,9 @@ static int st1202_led_pattern_set(struct led_classdev *ldev,
if (len > ST1202_MAX_PATTERNS)
return -EINVAL;

- for (int patt = 0; patt < len; patt++) {
- if (pattern[patt].delta_t < ST1202_MILLIS_PATTERN_DUR_MIN ||
- pattern[patt].delta_t > ST1202_MILLIS_PATTERN_DUR_MAX)
+ for (int pattern = 0; pattern < len; pattern++) {
+ if (patterns[pattern].delta_t < ST1202_MILLIS_PATTERN_DUR_MIN ||
+ patterns[pattern].delta_t > ST1202_MILLIS_PATTERN_DUR_MAX)
return -EINVAL;
}

@@ -251,12 +252,13 @@ static int st1202_led_pattern_set(struct led_classdev *ldev,
if (ret != 0)
return ret;

- for (int patt = 0; patt < len; patt++) {
- ret = st1202_pwm_pattern_write(chip, led->led_num, patt, pattern[patt].brightness);
+ for (int pattern = 0; pattern < len; pattern++) {
+ ret = st1202_pwm_pattern_write(chip, led->led_num, pattern,
+ patterns[pattern].brightness);
if (ret != 0)
return ret;

- ret = st1202_duration_pattern_write(chip, patt, pattern[patt].delta_t);
+ ret = st1202_duration_pattern_write(chip, pattern, patterns[pattern].delta_t);
if (ret != 0)
return ret;
}
--
2.55.0