Re: [PATCH] firewire: ohci: obsolete flushing field in at_context structure
From: Takashi Sakamoto
Date: Sun Sep 13 2026 - 03:54:17 EST
On Sat, Sep 12, 2026 at 12:22:19PM +0900, Takashi Sakamoto wrote:
> The flushing field in the at_context structure is used for the internal
> branches in handle_at_packet(). This field is enabled in
> at_context_flush() when either handling the selfIDComplete event in
> the threadedIRQ handler or calling the .remove callback of the PCI
> device.
>
> In these two flushing cases, the pointer to the work structure retrieved
> by current_work() should be different from the one in the at_context
> structure. Replacing the flushing field with a work structure check is
> preferable since the branching can be self-contained without relying on an
> external flag.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> ---
> drivers/firewire/ohci.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Applied to for-next branch.
Regards
Takashi Sakamoto