Re: [PATCH v2 4/4] pinctrl: renesas: rzt2h: reuse helpers

[Andy Shevchenko]

On Thu, Sep 10, 2026 at 07:02:26PM +0300, Cosmin Tanislav wrote:
> The PMCm peripheral-mode test, the PFCm function read, the PINm input
> read, the PMm write, and the PMm read are open-coded in several places.

> Reuse the already existing helpers.

...

> -		reg64 = rzt2h_pinctrl_readq(pctrl, port, PFC(port));
> -		reg64 = (reg64 >> (bit * 8)) & PFC_MASK;
> -		if (reg64 == PFC_FUNC_INTERRUPT)
> +		if (rzt2h_pin_read_pfc(pctrl, port, bit) == PFC_FUNC_INTERRUPT)
>  			return GPIO_LINE_DIRECTION_IN;

Basically this part with the helper should be split into a separate patch w/o
Fixes tag.

-- 
With Best Regards,
Andy Shevchenko