Re: [PATCH 1/4] dt-bindings: ufs: Add nvidia,tegra264-ufs

[Krzysztof Kozlowski]

On Wed, Sep 09, 2026 at 04:11:19PM +0530, Kartik Rajput wrote:
> +  clocks:
> +    items:
> +      - description: UFS host controller functional clock
> +      - description: UFS host controller divider clock
> +      - description: UFS reference clock (PLLREFUFS output)
> +      - description: UFS device-side reference clock
> +      - description: M-PHY reference clock (UPHY0 PLL4 digital output)
> +
> +  clock-names:
> +    items:
> +      - const: ufs

core? Names equal to block name are not really useful

> +      - const: div
> +      - const: ref
> +      - const: ref-dev
> +      - const: phy

Shouldn't the phy take its reference clock?

> +
> +  resets:
> +    items:
> +      - description: UFS host controller reset
> +      - description: UFS host controller AXI-master reset
> +      - description: UFS host controller low-power sequencer reset
> +
> +  reset-names:
> +    items:
> +      - const: ufs
> +      - const: axi
> +      - const: lp
> +
> +  phys:
> +    items:
> +      - description: M-PHY lane 0 transmit
> +      - description: M-PHY lane 0 receive
> +      - description: M-PHY lane 1 transmit
> +      - description: M-PHY lane 1 receive
> +
> +  phy-names:
> +    items:
> +      - const: mphy-l0-tx
> +      - const: mphy-l0-rx
> +      - const: mphy-l1-tx
> +      - const: mphy-l1-rx
> +
> +  iommus:
> +    maxItems: 1
> +
> +  dma-coherent: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names
> +  - phys
> +  - phy-names
> +  - iommus
> +  - dma-coherent
> +
> +allOf:
> +  - $ref: ufs-common.yaml
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/nvidia,tegra264.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/phy/nvidia,tegra264-mphy.h>

You need to decouple dependencies. Otherwise how is this supposed to be
checked with tools? If applied, you just broke maintainer's tree.


> +    #include <dt-bindings/reset/nvidia,tegra264.h>

Best regards,
Krzysztof