[PATCH 1/3] regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix
From: Tapio Reijonen
Date: Sun Sep 13 2026 - 07:40:53 EST
The feedback divider property was added without the standard unit
suffix. Rename mps,fb-voltage-divider to mps,fb-voltage-divider-ohms.
The suffix is worth more here than the convention alone: mps,mp886x.yaml
already describes a property of the exact same name whose values are in
kilo ohms, so two bindings from the same vendor spelled the resistances
identically while meaning different units. The suffix states the unit
where it cannot be missed.
Drop the explicit uint32-array $ref along with the rename. Properties
ending in -ohms are typed by property-units.yaml, which reports the type
error itself, so restating it only produced a duplicate complaint.
The binding has not appeared in a release and has no in-tree users, so
nothing depends on the old name. The driver is updated in the next patch.
Fixes: e3c05a881fc9 ("regulator: dt-bindings: Add MPS MPQ4210")
Suggested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll
Signed-off-by: Tapio Reijonen <tapio.reijonen@xxxxxxxxxxx>
---
Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
index e9e7a87e7533d0948927a459e9af711d1e07e572..c1914aa1a9d6236d5dbd4eaad3e05355f758155c 100644
--- a/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
+++ b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
@@ -34,16 +34,15 @@ properties:
be permanently asserted.
maxItems: 1
- mps,fb-voltage-divider:
+ mps,fb-voltage-divider-ohms:
description: An array of two integers containing the resistor values R1
- and R2 of the output feedback voltage divider in ohms.
- $ref: /schemas/types.yaml#/definitions/uint32-array
+ and R2 of the output feedback voltage divider.
maxItems: 2
required:
- compatible
- reg
- - mps,fb-voltage-divider
+ - mps,fb-voltage-divider-ohms
unevaluatedProperties: false
@@ -62,7 +61,7 @@ examples:
regulator-max-microvolt = <20000000>;
enable-gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
/* R1 = 82 kOhm, R2 = 9.1 kOhm */
- mps,fb-voltage-divider = <82000 9100>;
+ mps,fb-voltage-divider-ohms = <82000 9100>;
/* 50 mV/ms reference ramp x (82000 + 9100) / 9100 */
regulator-ramp-delay = <500>;
};
--
2.47.3