Re: [PATCH v2 2/2] arm64: zynqmp: Add ifm ZynqMP VHIP6 EvalBoard

[Peter Korsgaard]

>>>>> "Marek" == Marek Vasut <marex@xxxxxxxxxxxx> writes:

Hi,

 >> > +	chosen {
 >> > +		bootargs = "clk_ignore_unused";
 >> Why?

 > This can be dropped, thanks.

Good.

 >> > +	gpio-line-names =
 >> > +		/* GPIO 0 - 77 */
 >> > +		"", "", "", "", "", "", "", "", "", "",	"", "", "", "", "", "",
 >> > +		"", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "",
 >> > +		"", "", "", "", "",
 >> > +		"ifm_device_info_eeprom_wp",
 >> NIT: The dts references a number of other GPIOs, any specific reason
 >> to
 >> only name this one?
 > The legacy userspace tooling used to depend on it, used libgpiod to
 > look up this GPIO by name.

OK, but why not add all the referenced GPIOs if you fill out
gpio-line-names anyway?

-- 
Bye, Peter Korsgaard