Re: [PATCH v2 0/6] riscv: Make IPI_MAX visible and use it consistently

[Radu Rendec]

On Fri, 2026-09-11 at 03:27 +0000, Guo Ren wrote:
> This series removes the implicit assumption that RISC-V supports exactly
> eight IPI message types.
> 
> Currently, the SBI, CLINT and ACLINT SSWI IPI providers use
> BITS_PER_BYTE when sizing the generic IPI mux, while IMSIC carries a
> separate IMSIC_NR_IPI definition set to 8. These values happen to match
> IPI_MAX today, but neither is the proper source of truth for the number
> of RISC-V IPI message types.
> 
> Move enum ipi_message_type to asm/smp.h so IPI providers can use IPI_MAX
> directly, then replace the BITS_PER_BYTE and IMSIC_NR_IPI uses with
> IPI_MAX.
> 
> This also makes adding future RISC-V IPI message types independent of
> the current eight-entry assumption.
> 
> A follow-up patch renames the MediaTek VPU mailbox terminator from
> IPI_MAX to IPI_VPU_MAX. That token belongs to the VPU firmware IPI id
> enum and should follow the same prefixed convention as IPI_VPU_INIT
> (and SCP_IPI_MAX on the SCP side), instead of reusing the generic
> IPI_MAX name.
> 
> ---
> GUO Ren (XuanTie) (4):
>       clocksource: clint: Use IPI_MAX for IPI muxing
>       irqchip/aclint-sswi: Use IPI_MAX for IPI muxing
>       irqchip/imsic: Use IPI_MAX instead of IMSIC_NR_IPI
>       media: mtk-vpu: rename IPI_MAX to IPI_VPU_MAX
> 
> tip-bot2 for GUO Ren (XuanTie) (2):
>       riscv: smp: Move enum ipi_message_type to asm/smp.h
>       riscv: sbi: Use IPI_MAX for SBI IPI muxing

I am confused. Thomas merged your entire v1 series a week before (see
the individual replies from tip-bot2@xxxxxxxxxxxxx). Why are you
sending v2?

Patch 6 was not included in v1 (but it's clearly related), so perhaps
you meant to send only this one as a separate patch?

Also:
 * The cover letter should include a changelog, indicating what changes
   were made in each version compared to the previous one.
 * Patches 1 and 2 carry a "From:" tag that attributes authorship to
   tip-bot2, which is wrong (if these patches were to be applied).

> 
>  arch/riscv/include/asm/smp.h                  | 12 ++++++++++++
>  arch/riscv/kernel/sbi-ipi.c                   |  4 ++--
>  arch/riscv/kernel/smp.c                       | 12 ------------
>  drivers/clocksource/timer-clint.c             |  4 ++--
>  drivers/irqchip/irq-aclint-sswi.c             |  4 ++--
>  drivers/irqchip/irq-riscv-imsic-early.c       |  4 ++--
>  drivers/irqchip/irq-riscv-imsic-state.h       |  1 -
>  drivers/media/platform/mediatek/vpu/mtk_vpu.c | 12 ++++++------
>  drivers/media/platform/mediatek/vpu/mtk_vpu.h |  4 ++--
>  9 files changed, 28 insertions(+), 29 deletions(-)
> ---
> base-commit: 08df884136f1c1197bab2a27814404fd329d9aac
> change-id: 20260911-ipi_max-ff71eeadf6fd
> 
> Best regards,
> --  
> GUO Ren (XuanTie) <guoren@xxxxxxxxxx>