Re: [PATCH v3 7/7] block: remove dead metadata handling from the async direct I/O path

[Tal Zussman]

On 9/10/26 6:40 AM, Hannes Reinecke wrote:
> On 9/10/26 12:05 AM, Tal Zussman wrote:
>> Since commit 2729a60bbfb9 ("block: don't silently ignore metadata for
>> sync read/write"), blkdev_direct_IO() sends every IOCB_HAS_METADATA
>> request to __blkdev_direct_IO(). Remove the now unreachable metadata
>> mapping in __blkdev_direct_IO_async() and the unmap in its completion
>> handler.
>> 
>> No functional change.
>> 
>> Assisted-by: Claude:claude-fable-5
>> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>
>> ---
>>   block/fops.c | 10 ----------
>>   1 file changed, 10 deletions(-)
>> 
> Maybe a 'Fixes' tag, since you already referenced the commit?
> 

No need, I think, since it doesn't actually fix a bug.

> Reviewed-by: Hannes Reinecke <hare@xxxxxxxxxx>
> 

Thanks!

> Cheers,
> 
> Hannes
> -- 
> Dr. Hannes Reinecke                  Kernel Storage Architect
> hare@xxxxxxx                                +49 911 74053 688
> SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
> HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
>