Re: [PATCH] iio: temperature: tsys02d: Fix state desynchronization on resolution write error

[Jonathan Cameron]

On Tue, 8 Sep 2026 13:32:44 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Mon, Sep 07, 2026 at 04:50:09PM +0200, Joshua Crofts wrote:
> > On Mon,  7 Sep 2026 09:53:53 +0100
> > Salah Triki <salah.triki@xxxxxxxxx> wrote:  
> 
> ...
> 
> > >  		ret = ms_sensors_write_resolution(dev_data, i);
> > > +		if (!ret)
> > > +			dev_data->res_index = i;  
> > 
> > + blank line
> >   
> > >  		mutex_unlock(&dev_data->lock);
> > >  
> > >  		return ret;  
> > 
> > Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>  
> 
> Actually we prefer usual pattern — "check for error first".
> This 'if (!ret)' is confusing.
> 

I'd use a guard so we can just return when the error is seen.