Re: [PATCH v3] mfd: intel-lpss: Fix DebugFS initialization

[Andy Shevchenko]

On Sun, Sep 13, 2026 at 05:53:53PM +0500, Maria Lisina via B4 Relay wrote:

This is a fair report and patch, but three versions over a night?!
Please, slow down! Even with this kind of patch you have to wait
at least 24h between versions.

> The original code defers DebugFS check with unnecessary warning message
> which also appears when DebugFS is simply disabled.
> 
> Therefore it spams dmesg with these messages:
> 
>   intel-lpss 0000:00:15.0: Failed to create debugfs entries
>   intel-lpss 0000:00:15.3: Failed to create debugfs entries
>   intel-lpss 0000:00:1e.0: Failed to create debugfs entries
>   intel-lpss 0000:00:1e.2: Failed to create debugfs entries

One message is enough as an example.

> This patch adds proper checks to intel_lpss_init() and
> intel_lpss_debugfs_add() functions and removes warning message.

...

> -	ret = intel_lpss_debugfs_add(lpss);
> -	if (ret)
> -		dev_warn(dev, "Failed to create debugfs entries\n");
> +	intel_lpss_debugfs_add(lpss);

Obviously this message is added here deliberately. If you are annoyed by it,
we may consider dropping the level.

...

> +	/* Ensure intel_lpss_debugfs stays NULL on error,
> +	 * so intel_lpss_debugfs_add() exits properly.
> +	 */

/*
 * Wrong comment style for multi-line
 * comments.
 */

...

TL;DR: moving from warn to info or debug level  would be a good compromise.

-- 
With Best Regards,
Andy Shevchenko