Re: [PATCH v8 6/9] iio: accel: mma8452: Add comment block for struct mma8452_data
From: Esben Haabendal
Date: Mon Sep 14 2026 - 02:51:24 EST
"Jonathan Cameron" <jic23@xxxxxxxxxx> writes:
> On Mon, 07 Sep 2026 16:51:01 +0200
> Esben Haabendal <esben@xxxxxxxxxx> wrote:
>
>> The struct mma8452_data is central for this driver, and it makes sense to
>> have a description of the fields in it to make it easier to work with the
>> driver.
>>
>> Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
>> ---
>> drivers/iio/accel/mma8452.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index c6af68d2a297..2c1b97b77bc1 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -104,6 +104,22 @@
>>
>> #define MMA8452_AUTO_SUSPEND_DELAY_MS 2000
>>
>> +/**
>> + * struct mma8452_data - IIO device private data structure
>> + * @client: the I2C client object
>> + * @lock: mutex for synchronziation of register
>> + * read-modify-write and holding chip in STANDBY
>> + * mode while writing to registers
>> + * @orientation: mounting matrix, flipped axis etc
>> + * @chip_info: chip specific data
>> + * @vdd_reg: reference to VDD regulator
>> + * @vddio_reg: reference to VDDIO regulator
>
> These don't exist any more. Sanjay did a conversion to bulk regulators
> that I picked up a few weeks back. Please rebase for v9 on top
> of the togreg branch of iio.git.
Already done and queued up to be sent :)
> Seems that sashiko figured out enough to base this on a more recent
> tree than you have.
/Esben