Re: [PATCH 2/6] ASoC: meson: add audin main module and I2S formatter

[Uwe Kleine-König]

Hello Valerio,

On Sat, Sep 12, 2026 at 12:14:32AM +0200, Valerio Setti wrote:
> +#include <linux/clk.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/of_platform.h>
> +#include <linux/platform_device.h>

Please rely on <linux/platform_device.h> to provide of_device_id and
drop the include for <linux/mod_devicetable.h>. That latter header is
supposed to go away soon and injects a lot of build dependencies into
your driver.

If you want to go full iwyn, please use <linux/device-id/of.h> instead.

> +#include <linux/regmap.h>
> +#include <linux/reset.h>
> +#include <sound/soc.h>
> [...]
> +static const struct of_device_id meson_gx_audin_of_match[] = {
> +	{ .compatible = "amlogic,meson-gxbb-audin" },
> +	{ .compatible = "amlogic,meson-gxl-audin" },
> +	{}
> +};

It seems to be subjective, but I think most nit-pickers in the kernel
prefer { } over {} to match the spacing in the non-empty initializers.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature