Re: [PATCH v4 1/2] interconnect: qcom: Make important drivers default

[Abel Vesa]

On 26-09-14 08:44:04, Krzysztof Kozlowski wrote:
> The interconnect drivers for Qualcomm SoC Network-on-Chip are covering a
> basic or fundamental SoC feature: bandwidth management between internal
> SoC blocks.  SoC can boot without these, but power management or
> performance will be affected.  These drivers do not represent any sort
> of buses visible to the board designers/configurators, thus they should
> be always enabled, regardless how SoC is used in the final board.
> 
> Kernel configuration should not ask users choice of drivers when that
> choice is obvious and known to the developers that answer should be
> 'yes' or 'module'.
> 
> Switch all almost Qualcomm interconnect drivers to a default 'yes' for
> ARCH_QCOM.  This has impact:
> 
> 1. arm64 defconfig:
>    a. Enable as built-in INTERCONNECT_QCOM_HAWI, INTERCONNECT_QCOM_NORD,
>       INTERCONNECT_QCOM_SHIKRA, INTERCONNECT_QCOM_SDM660,
>       INTERCONNECT_QCOM_SDM670, INTERCONNECT_QCOM_SM7150 and
>       INTERCONNECT_QCOM_SAR2130P, which were not selected before but
>       should be, because these platforms need them anyway for proper
>       functioning.
> 
>    b. Switch to built-in from a module INTERCONNECT_QCOM_QCS404 and
>       INTERCONNECT_QCOM_MSM8916, which as modules would not make the
>       platform bootable in most cases, and INTERCONNECT_QCOM_OSM_L3,
>       which when module might slow down boot considerably by having
>       caches running at slow speed.
> 
> 2. arm qcom_defconfig: Switch to built-in from a module
>    INTERCONNECT_QCOM_RPMH, INTERCONNECT_QCOM_SMD_RPM,
>    INTERCONNECT_QCOM_BCM_VOTER, INTERCONNECT_QCOM_MSM8974,
>    INTERCONNECT_QCOM_SDX55, which as modules would not make the
>    platform bootable in most cases.
> 
> 3. arm multi_v7 defconfig: Enable drivers necessary to boot
>    ARM 32-bit platforms, which are already enabled on qcom_defconfig:
> 
>    a. Enable as built-in INTERCONNECT_QCOM_MSM8974.
>    b. Enable as modules (other dependencies prevent from built-in)
>       INTERCONNECT_QCOM_RPMH, INTERCONNECT_QCOM_BCM_VOTER and
>       INTERCONNECT_QCOM_SDX55.
> 
> 4. COMPILE_TEST builds: Enable by default all drivers for arm or arm64
>    builds, whenever ARCH_QCOM is selected.  This has impact on build
>    time and feels logical, because if one selects ARCH_QCOM then
>    probably by default wants to build test it entirely.  Kernels with
>    COMPILE_TEST are not supposed to be used for booting.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>