Re: [PATCH] x86/sev: Do not fail SNP platform init if the vTPM cannot be registered
From: Stefano Garzarella
Date: Mon Sep 14 2026 - 04:04:37 EST
On Sat, Sep 12, 2026 at 11:54:54PM +0530, Gokul K wrote:
I'm opposed convert to an error message, but honestly I don't understand
which problem we are fixing.
Sorry, of course I meant "I'm NOT opposed to"!
Only an inconsistency: no vTPM returns 0, a failed registration returns
-ENODEV, both leave sev-guest registered, and nothing reads the return
value. The failure itself should not happen in practice and I am not
arguing otherwise.
Happy to drop this if you would rather keep the -ENODEV.
Up to the maintainers. I'm fine with both, but TBH if SVSM tells us it has a TPM device and we can't register the device in the system, something is seriously wrong, so returning an error seems fine to me, since we were not able to properly configure the SNP platform.
Thanks,
Stefano