Re: [PATCH v5 1/4] dt-bindings: arm: rockchip: Add FriendlyElec NanoPi R28S

[Jonas Karlman]

Hi,

On 9/14/2026 10:24 AM, 安容 via B4 Relay wrote:
> From: 安容 <HystericalDragons@xxxxxxxxx>
> 
> The NanoPi R28S is a dual gigabit Ethernet router board based on the
> Rockchip RK3528 SoC.
> 
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: 安容 <HystericalDragons@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 81744fbee9..709e2cc44d 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -347,6 +347,11 @@ properties:
>                - friendlyarm,nanopi-r2s-plus
>            - const: rockchip,rk3328
>  
> +      - description: FriendlyElec NanoPi R28S
> +        items:
> +          - const: friendlyarm,nanopi-r28s

Maybe instead add this board as a variant under existing NanoPi Zero2,
seeing how it will share a common .dtsi-file with Zero2, and also with
the NEO3 Plus once this series lands.

      - description: FriendlyElec NanoPi R28S/Zero2
        items:
          - enum:
              - friendlyarm,nanopi-r28s
              - friendlyarm,nanopi-zero2
          - const: rockchip,rk3528

Regards,
Jonas

> +          - const: rockchip,rk3528
> +
>        - description: FriendlyElec NanoPi R3S
>          items:
>            - const: friendlyarm,nanopi-r3s
>