Re: [PATCH 2/2] staging: sm750fb: remove unused definitions from ddk750_reg.h

From: Dan Carpenter

Date: Mon Sep 14 2026 - 05:22:31 EST


On Sun, Sep 13, 2026 at 04:01:40AM +0000, Gabriel Changamire wrote:
> The sm750fb TODO asks for unused code to be removed. Of the 1203
> register and field definitions in ddk750_reg.h, 1046 are referenced
> neither by the rest of the driver nor, transitively, by any definition
> that is referenced.
>
> Remove them, together with section comments that are left with no
> content beneath them. The include guard and all VALIDATION_CHIP
> conditional blocks are preserved.
>
> Build-tested: all driver objects are byte-identical before and after
> the change. No functional change.
>
> Signed-off-by: Gabriel Changamire <gaberashawn@xxxxxxxxx>
> ---

These macros are just documentation and they don't hurt readability.
They probably improve readability.

regards,
dan carpenter