Re: [PATCH] staging: fbtft: replace number with sizeof()

[Andy Shevchenko]

On Mon, Sep 14, 2026 at 12:09 PM Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:
>
> Replace integer number with sizeof with the goal of prevent future truncation bugs.

preventing

>
> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>

So far I see only a single patch, what are the "future truncation
bugs" you are talking about?

...

>  static unsigned int read_devicecode(struct fbtft_par *par)
>  {
> -       u8 rxbuf[8] = {0, };
> +       u8 rxbuf[sizeof(u64)] = {0, };

This is an unclear change. Where did u64 come from? Why do we even
need a 8-byte buffer when we only do 4-byte operations?

>         write_reg(par, 0x0000);
>         par->fbtftops.read(par, rxbuf, 4);

Perhaps you need to read a datasheet for this panel and come up with a
better understanding?

-- 
With Best Regards,
Andy Shevchenko