Re: [PATCH v50 3/7] firmware: imx: add driver for NXP EdgeLock Enclave

[Frieder Schrempf]

On 14.09.26 12:45, Frieder Schrempf wrote:
> On 12.09.26 19:03, pankaj.gupta@xxxxxxxxxxx wrote:
>> From: Pankaj Gupta <pankaj.gupta@xxxxxxx>
>>
>> Add MU-based communication interface for secure enclave.
>>
>> NXP hardware IP(s) for secure-enclaves like Edgelock Enclave(ELE), are
>> embedded in the SoC to support the features like HSM, SHE & V2X, using
>> message based communication interface.
>>
>> The secure enclave FW communicates with Linux over single or multiple
>> dedicated messaging unit(MU) based interface(s).
>> Exists on i.MX SoC(s) like i.MX8ULP, i.MX93, i.MX95 etc.
>>
>> For i.MX9x SoC(s) there is at least one dedicated ELE MU(s) for each
>> world - Linux(one or more) and OPTEE-OS (one or more).
>>
>> Other dependent kernel drivers will be:
>> - NVMEM: that supports non-volatile devices like EFUSES,
>>   managed by NXP's secure-enclave.
>>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>
>> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>> Tested-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> 
> My review was for v25, my test was valid for v29. We are now at v50, so
> please, as requested before, drop the tags as I don't think they can be
> considered to be still valid with all these changes.
Sorry, I missed that you already removed the R-b in the meantime. But I
guess the T-b should also go. Please ping me when all the problems in
the code are solved and I will test once more.