Re: [PATCH RFC 20/20] arm64: dts: qcom: generalmobile-shamrock: new device

[David Heidelberg]

On 14/09/2026 14:03, David Heidelberg wrote:
> On 14/09/2026 13:58, Muzaffer Kadir wrote:
> > Hi Konrad,
> >
> > On Mon, 14 Sep 2026 13:22:52 +0200, Konrad Dybcio wrote:
> > > On 9/12/26 10:39 AM, Muzaffer Kadir via B4 Relay wrote:
> > > > From: Muzaffer Kadir <muzafferkadir@xxxxxxxxxxxxxx>
> > > >
> > > > Add General Mobile Shamrock (GM 5 Plus).
> > > > Shamrock is designed similar to L9300.
> > > > Downstream reference is [1].
> > >
> > > Please feel free to
> > > wrap your messages at 72
> > > characters, otherwise they are
> > > a bit hard to read! :D
> >
> > I am sorry to hear that. vim shows
> > it less than 72 and I can't see which
> > line is bigger than 72.
>
> Hehe, yeah, had the same issue.
>
> require('lualine').setup {
>    options = {
>      icons_enabled = true,
>      theme = 'auto',
>      component_separators = { left = '', right = '|'},
>      section_separators = { left = '', right = ''},
>      disabled_filetypes = {
>        statusline = {},
>        winbar = {},
>      },
>      ignore_focus = {},
>      always_divide_middle = true,
>      globalstatus = false,
>      refresh = {
>        statusline = 1000,
>        tabline = 1000,
>        winbar = 1000,
>      }
>    },
>    sections = {
>      lualine_a = {'mode'},
>      lualine_b = {'branch', 'diff', 'diagnostics'},
>      lualine_c = {'filename'},
>      lualine_x = {'filetype'},
>      lualine_y = {'progress'},
>      lualine_z = {
>        { '%3l:%-2.(%c%V%)', type = 'stl' },
>      },
>    },
>    inactive_sections = {
>      lualine_a = {},
>      lualine_b = {},
>      lualine_c = {'filename'},
>      lualine_x = {'location'},
>      lualine_y = {},
>      lualine_z = {}
>    },
>    tabline = {},
>    winbar = {},
>
>    inactive_winbar = {},
>
>    extensions = {}
>
> }
>
> see a lualine_z for the way how to let neovim show length INCLUDING tabs :)

...aaaand the comment was about opposite problem then the one I tried to address.

Sorry for the noise.

> David
>
> > Only one I can see is url itself.
> > Should I move url to Link trailer?
> >
> > For other parts of review,
> > I will fix them in v2.
> > Thanks a lot for review.
> >
> > Best regards,
> > Muzaffer Kadir