Re: [PATCH v2 02/13] ASoC: mediatek: mt8189: Propagate APLL enable errors

[Mark Brown]

On Mon, Sep 14, 2026 at 03:22:21PM +0200, AngeloGioacchino Del Regno wrote:
> On 9/14/26 09:28, phucduc.bui@xxxxxxxxx wrote:

> > +	ret = regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG,
> 
> Well, this is a bit of defensive programming here.
> 
> The regmap pointer is already checked by the previous function call, and this is
> a regmap over MMIO... and MMIO writes can't fail.

Oh, you sweet summer child :) .  Though practically speaking the error
handling ends up being the same as if they couldn't fail since if
something goes wrong it's generally catastrophic stuff like locking the
core up completely so the end result is the same.

Attachment: signature.asc
Description: PGP signature