Re: [PATCH v5] HID: appletb-kbd: support layer switching on Fn double press

[Jiri Kosina]

On Fri, 11 Sep 2026, Aditya Garg wrote:

> Holding Fn temporarily switches the Touch Bar between media controls and
> function keys. Users who want to keep the alternate layer currently need
> to change the mode through sysfs.
> 
> An optional double_press_switch_time module parameter makes a double press
> persistently switch the default layer. Its value specifies the double-press
> interval in milliseconds, while zero leaves the behavior disabled.
> 
> Signed-off-by: Aditya Garg <aditya.garg@xxxxxxxxx>
> Signed-off-by: Andre Eikmeyer <dev@deq.rocks>
> ---
> Changes in v2:
> - Added a check to ensure negative fn switch times are ignored.
> 
> Changes in v3:
> - Renamed the backing variable to match the module parameter.
> - Fixed the reported code style issues.
> 
> Changes in v4:
> - Added missing "break;" in case statements.
> - Change author's email to aditya.garg@xxxxxxxxx
> 
> Changes in v5:
> - Remove the break; statements added by mistake in v4.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs