Re: [PATCH v4 06/16] f2fs: stop using PG_private

From: David Hildenbrand (Arm)

Date: Mon Sep 14 2026 - 10:55:46 EST


On 9/14/26 04:24, Zi Yan wrote:
> f2fs sets its PAGE_PRIVATE_* flags in page->private and checking
> page->private != NULL is equivalent to checking PG_private. Change
> PagePrivate() to page_private(). Meanwhile, in set_page_private_##name(),
> page->private is first set to 0/NULL before an PAGE_PRIVATE_* flag is set,
> but it can cause confusion when PG_private is removed and
> page->private != NULL is used instead. Change it to initialize
> page->private to PAGE_PRIVATE_NOT_POINTER instead and retain the original
> semantics.
>
> It prepares for a future commit that removes PG_private.
>
> No functional change intended.
>
> Assisted-by: LLM
> To: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> To: Chao Yu <chao@xxxxxxxxxx>
> Cc: linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Acked-by: Usama Arif <usama.arif@xxxxxxxxx>
> Acked-by: Chao Yu <chao@xxxxxxxxxx>
> Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
> ---

Reviewed-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

--
Cheers,

David