Re: [PATCH 14/17] i3c: mipi-i3c-hci: Remove invalid HDR-BT and Fm/Fm+ definitions

[Frank Li]

On Mon, Sep 14, 2026 at 02:30:00PM +0300, Adrian Hunter wrote:
> Several HCI definitions describe capabilities or modes that are not
> defined by any released version of the I3C HCI specification.
>
> HC_CAP_HDR_BT_EN uses a reserved HC_CAPABILITIES bit. Similarly,
> MODE_I3C_HDR_BT uses a MODE value reserved for I3C transfers, while
> MODE_I3C_Fm_FmP cannot be encoded in the 3-bit Command Descriptor MODE
> field.
>
> These definitions are currently unused, so there is no functional
> change.  Remove them to avoid implying support for non-existent HCI
> features and to prevent future misuse.
>
> Assisted-by: GitHub-Copilot:claude-opus-5
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 --
>  drivers/i3c/master/mipi-i3c-hci/core.c   | 1 -
>  2 files changed, 3 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> index 3b9345718d27..9910df53c013 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> @@ -108,8 +108,6 @@ enum hci_cmd_mode {
>  	MODE_I3C_SDR4		= 0x4,
>  	MODE_I3C_HDR_TSx	= 0x5,
>  	MODE_I3C_HDR_DDR	= 0x6,
> -	MODE_I3C_HDR_BT		= 0x7,
> -	MODE_I3C_Fm_FmP		= 0x8,
>  	MODE_I2C_Fm		= 0x0,
>  	MODE_I2C_FmP		= 0x1,
>  	MODE_I2C_UD1		= 0x2,
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 4629a16debc9..7a39be64c4e1 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -55,7 +55,6 @@
>  #define HC_CAP_DIRECT_COMMANDS_EN	BIT(18)
>  #define HC_CAP_MULTI_LANE_EN		BIT(15)
>  #define HC_CAP_CMD_CCC_DEFBYTE		BIT(10)
> -#define HC_CAP_HDR_BT_EN		BIT(8)
>  #define HC_CAP_HDR_TS_EN		BIT(7)
>  #define HC_CAP_HDR_DDR_EN		BIT(6)
>  #define HC_CAP_NON_CURRENT_MASTER_CAP	BIT(5)	/* master handoff capable */
> --
> 2.53.0
>