Re: [PATCH] hwmon: (w83791d) remove fan/pwm 4-5 sysfs group on remove

[Guenter Roeck]

On Mon, Sep 14, 2026 at 02:28:09PM +0800, Guangshuo Li wrote:
> When the fan/pwm 4-5 pins are not used as GPIO, w83791d_probe()
> creates the w83791d_group_fanpwm45 sysfs group on the I2C client
> device.
> 
> The probe error path removes this group when a later initialization
> step fails, but the normal remove path only removes w83791d_group.
> As a result, the optional fan/pwm 4-5 sysfs files can remain after the
> driver is unbound.
> 
> The callbacks associated with these files access the driver data,
> which is devm allocated and released after driver unbind. Leaving the
> sysfs files behind can therefore result in accesses to stale driver
> data.
> 
> Remove w83791d_group_fanpwm45 during normal teardown as well.
> 
> This issue was found by manual code inspection.
> 
> Fixes: 6e1ecd9b8f13 ("hwmon: (w83791d) fan 4/5 pins can also be used for gpio")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>

Applied.

Thanks,
Guenter