Re: [PATCH v4 01/15] arm64: dts: ti: k3-am62a: Fix MMC0_CLK register address

[Kumar, Udit]

Thanks Judith

On 9/11/2026 10:24 PM, Judith Mendez wrote:
> Hi Udit,
> 
> On 9/11/26 2:57 AM, Kumar, Udit wrote:
>>
>>
>> On 9/10/2026 3:17 AM, Judith Mendez wrote:
>>> MMC0_CLKLB and MMC0_CLK have incorrectly swapped register addresses
>>> as per datasheet [0]. Set the correct MMC0_CLK address and drop the
>>> unneeded MMC0_CLKLB pin configuration.
>>>
>>> [0] https://www.ti.com/lit/gpn/am62a7 Rev. E: Table 5-1. Pin Attributes
>>>
>>> Fixes: e041ec6e86e7 ("arm64: dts: ti: k3-am62a7-sk: Enable eMMC
>>> support")
>>> Cc: <stable@xxxxxxxxxxxxxxx>
>>> Signed-off-by: Judith Mendez <jm@xxxxxx>
>>> Reviewed-by: Moteen Shah <m-shah@xxxxxx>
>>> ---
>>>   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/
>>> boot/dts/ti/k3-am62a7-sk.dts
>>> index d3b3675e7a8fc..b04636cab71c7 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>> @@ -328,8 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24)
>>> GPMC0_CSn3.I2C2_SDA */
>>>       main_mmc0_pins_default: main-mmc0-default-pins {
>>>           pinctrl-single,pins = <
>>>               AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */
>>> -            AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLKLB */
>>> -            AM62AX_IOPAD(0x21c, PIN_INPUT, 0) /* (AB1) MMC0_CLK */
>>> +            AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */
>>
>> Shouldn't be MMC0_CLK be o/p, instead of  PIN_INPUT
>> Similar to patch [0]
>> [0] https://lore.kernel.org/all/20260909214743.899477-4-jm@xxxxxx/
> 
> Yes it should, and it is in the same series as  you pointed out. This
> current patch only fixes register address as per commit description. (:
> 

I see. These can be merged into one patch,
Anyway,
Acked-by: Udit Kumar <u-kumar1@xxxxxx> (for fixing offset)

> ~ Judith
> 
>>
>>
>>
>>>               AM62AX_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */
>>>               AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1)
>>> MMC0_DAT1 */
>>>               AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3)
>>> MMC0_DAT2 */
>>
>