Re: [PATCH 1/3] mm/vmalloc: group xa_init with vbq field initializations

From: Uladzislau Rezki

Date: Mon Sep 14 2026 - 14:30:02 EST


On Mon, Sep 14, 2026 at 11:34:00AM +0800, Ye Liu wrote:
> From: Ye Liu <liuye@xxxxxxxxxx>
>
> Move xa_init() next to the other vbq field initializations instead of
> after the unrelated vfree_deferred setup.
>
> Signed-off-by: Ye Liu <liuye@xxxxxxxxxx>
> ---
> mm/vmalloc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 859e6d2d57a3..117483dd048c 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -5585,10 +5585,11 @@ void __init vmalloc_init(void)
> vbq = &per_cpu(vmap_block_queue, i);
> spin_lock_init(&vbq->lock);
> INIT_LIST_HEAD(&vbq->free);
> + xa_init(&vbq->vmap_blocks);
> +
> p = &per_cpu(vfree_deferred, i);
> init_llist_head(&p->list);
> INIT_WORK(&p->wq, delayed_vfree_work);
> - xa_init(&vbq->vmap_blocks);
> }
>
> /*
>
> --
> 2.25.1
>
LGTM:

Reviewed-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>

--
Uladzislau Rezki