Re: [RFC PATCH net-next v2 0/7] net: mdio: an MDIO device driver for the Airoha EN8811H

[Andrew Lunn]

On Thu, Sep 10, 2026 at 08:49:16PM +0000, Aleksei Sviridkin wrote:
> Two of the things I said I would do turned out not to be doable as
> stated.
> 
> > It is fine. I would also add a select or depends on the PHY driver
> > Kconfig stanza to link it to the MDIO_AIROHA_EN8811H driver.
> 
> Kconfig refuses it:
> 
>   symbol AIR_EN8811H_PHY is implied by MDIO_AIROHA_EN8811H
>   symbol MDIO_AIROHA_EN8811H is implied by AIR_EN8811H_PHY
>   error: recursive dependency detected!

O.K. So there is a linkage anyway.

> > The location is fine. MAINTAINERS need to list it. What you might want
> > to do is list it twice, once in the PHY driver MAINTAINERS record, and
> > again in the MDIO driver section.
> 
> There is no PHY driver record to put it in. Neither air_en8811h.c nor
> the shared air_phy_lib.c is claimed by any entry, so the header sits in
> the MDIO record alone. I can add a record covering both files, but that
> puts my name on code I did not write. Tell me which you would rather
> see.

That not great.

$ ./scripts/get_maintainer.pl drivers/net/phy/air_en8811h.c
Andrew Lunn <andrew@xxxxxxx> (maintainer:ETHERNET PHY LIBRARY)
Heiner Kallweit <hkallweit1@xxxxxxxxx> (maintainer:ETHERNET PHY LIBRARY)
Russell King <linux@xxxxxxxxxxxxxxx> (reviewer:ETHERNET PHY LIBRARY)
"David S. Miller" <davem@xxxxxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <edumazet@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <pabeni@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)

The usual generic suspects. Turning on some knobs you can additionally
get:

"Bjørn Mork" <bjorn@xxxxxxx> (commit_signer:3/9=33%,authored:3/9=33%,added_lines:412/668=62%,removed_lines:34/318=11%)
Louis-Alexis Eyraud <louisalexis.eyraud@xxxxxxxxxxxxx> (commit_signer:3/9=33%,authored:3/9=33%,added_lines:58/668=9%,removed_lines:258/318=81%)

Maybe reach out an see if they want to be listed as Maintainer.

      Andrew