Re: [PATCH v2 1/4] perf annotate-data: Convert type histogram to hashmap
From: Arnaldo Carvalho de Melo
Date: Mon Sep 14 2026 - 15:27:09 EST
On Mon, Sep 14, 2026 at 03:56:35PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Sep 14, 2026 at 08:22:06PM +0800, Tengda Wu wrote:
> > On 2026/9/14 14:45, Namhyung Kim wrote:
> > > The type histogram maintains sample counts and periods per offset. Use
> > > a hashmap instead of an array to reduce the memory overhead.
>
> > > No functional changes intended.
> <SNIP>
> > > - struct type_hist **histograms;
> > > + struct type_hist *histograms;
> > > };
>
> > > extern struct annotated_data_type unknown_type;
>
> > Reviewed-by: Tengda Wu <wutengda@xxxxxxxxxxxxxxx>
>
> I'm cherry picking this first patch, as I'll need to rebase my branch on
> top of it and thus testing it as I go developing it, sashiko found no
> problems and Tengda reviewed it.
It is now in tmp.perf-tools-next, will do the usual set of containerized
build tests and push,
- Arnaldo