Re: [PATCH net v10 01/14] rxrpc: Fix lack of short-send handling in rxrpc_kernel_send_data()

[David Laight]

On Mon, 14 Sep 2026 16:13:25 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Fix rxrpc_kernel_send_data() to loop around if it detects a short send.
> David Laight suggested doing it here rather than wrapping all the calls in
> loops.  Further, remove the len argument and use the iterator count instead
> and return 0 on success, not the amount copied.
> 
> Note this is also a prerequisite for changing the way rxrpc_send_data()
> works to return a short send rather than an error if some data was
> buffered.
> 
> Fixes: 651350d10f93 ("[AF_RXRPC]: Add an interface to the AF_RXRPC module for the AFS filesystem to use")
> Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824091645.415423-1-dhowells%40redhat.com
> Suggested-by: David Laight <david.laight.linux@xxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
> cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> cc: Simon Horman <horms@xxxxxxxxxx>
> cc: linux-afs@xxxxxxxxxxxxxxxxxxx
> cc: stable@xxxxxxxxxxxxxxx
> ---
>  Documentation/networking/rxrpc.rst |  6 ++++--
>  fs/afs/rxrpc.c                     | 28 ++++++++++----------------
>  include/net/af_rxrpc.h             |  5 ++---
>  net/rxrpc/rxperf.c                 | 11 +++-------
>  net/rxrpc/sendmsg.c                | 32 ++++++++++++++++++++----------
>  5 files changed, 42 insertions(+), 40 deletions(-)
> 
...
> diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c
> index d82916657a3d..09d9da92a1be 100644
> --- a/fs/afs/rxrpc.c
> +++ b/fs/afs/rxrpc.c
...
> @@ -912,21 +910,17 @@ void afs_send_simple_reply(struct afs_call *call, const void *buf, size_t len)
>  	msg.msg_controllen	= 0;
>  	msg.msg_flags		= 0;
>  
> -	n = rxrpc_kernel_send_data(net->socket, call->rxcall, &msg, len,
> +	n = rxrpc_kernel_send_data(net->socket, call->rxcall, &msg,
>  				   afs_notify_end_reply_tx);

Probably needs s/n/ret/

...
> diff --git a/include/net/af_rxrpc.h b/include/net/af_rxrpc.h
> index 0fb4c41c9bbf..f3980348ed34 100644
> --- a/include/net/af_rxrpc.h
> +++ b/include/net/af_rxrpc.h
> @@ -64,9 +64,8 @@ struct rxrpc_call *rxrpc_kernel_begin_call(struct socket *sock,
>  					   bool upgrade,
>  					   enum rxrpc_interruptibility interruptibility,
>  					   unsigned int debug_id);
> -int rxrpc_kernel_send_data(struct socket *, struct rxrpc_call *,
> -			   struct msghdr *, size_t,
> -			   rxrpc_notify_end_tx_t);
> +int rxrpc_kernel_send_data(struct socket *sock, struct rxrpc_call *call,
> +			   struct msghdr *msg, rxrpc_notify_end_tx_t notify_end_tx);
>  int rxrpc_kernel_recv_data(struct socket *, struct rxrpc_call *,
>  			   struct iov_iter *, size_t *, bool, u32 *, u16 *);
>  bool rxrpc_kernel_abort_call(struct socket *, struct rxrpc_call *,
> diff --git a/net/rxrpc/rxperf.c b/net/rxrpc/rxperf.c
> index b8df6d22314d..dad04062213f 100644
> --- a/net/rxrpc/rxperf.c
> +++ b/net/rxrpc/rxperf.c
> @@ -525,12 +525,10 @@ static int rxperf_process_call(struct rxperf_call *call)
>  		iov_iter_bvec(&msg.msg_iter, WRITE, &bv, 1, len);
>  		msg.msg_flags = MSG_MORE;
>  		n = rxrpc_kernel_send_data(rxperf_socket, call->rxcall, &msg,
> -					   len, rxperf_notify_end_reply_tx);
> +					   rxperf_notify_end_reply_tx);

Ditto

David