Re: [PATCH] scsi: libiscsi_tcp: check the data direction of a Data-In PDU

[Mike Christie]

On 8/1/26 8:36 AM, Yehyeong Lee wrote:
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index e90805ba868f..0283c4444cd0 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -480,6 +480,9 @@ static int iscsi_tcp_data_in(struct iscsi_conn *conn, struct iscsi_task *task)
>  	int datasn = be32_to_cpu(rhdr->datasn);
>  	unsigned total_in_length = task->sc->sdb.length;
>  
> +	if (task->sc->sc_data_direction != DMA_FROM_DEVICE)
> +		return ISCSI_ERR_PROTO;
> +
Sorry for the late response. Looks ok to me.

Reviewed-by: Mike Christie <michael.christie@xxxxxxxxxx>