Re: [PATCH 1/1] net: qrtr: fix coding style issues flagged by checkpatch

[Jakub Kicinski]

On Sun, 13 Sep 2026 23:33:42 +0530 Murali Krishna wrote:
> Fix several coding style issues in the QRTR subsystem detected by
> checkpatch --strict:
> 
> - af_qrtr.c: fix missing space in pointer cast, "(u8*)" should be
>   "(u8 *)" (ERROR)
> - af_qrtr.c: move trailing "*/" to a separate line in two multi-line
>   block comments to match kernel comment style (WARNING)
> - af_qrtr.c: add missing parameter names to the enqueue_fn function
>   pointer declaration in qrtr_sendmsg() (WARNING)
> - ns.c: remove unnecessary return statement at end of void function
>   service_announce_del() (WARNING)

You seem to have ignored all the automated messages telling you to slow
down. And we do not accept checkpatch fixes, please see below.

Please do not send any more patches to networking for a month.


Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches