Re: [PATCH 2/8] perf debuginfo: Fetch debuginfo keyed by build ID using debuginfod

[Arnaldo Carvalho de Melo]

On Mon, Sep 14, 2026 at 01:25:53PM -0700, Namhyung Kim wrote:
> On Sun, Sep 13, 2026 at 10:51:07PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Sun, Sep 13, 2026 at 06:34:44PM -0700, Namhyung Kim wrote:
> > > On Sun, Sep 13, 2026 at 07:28:14PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > +++ b/tools/perf/builtin-annotate.c
> > > > @@ -733,6 +733,8 @@ int cmd_annotate(int argc, const char **argv)
> > > >  	OPT_BOOLEAN(0, "stdio2", &annotate.use_stdio2, "Use the stdio interface"),
> > > >  	OPT_BOOLEAN(0, "ignore-vmlinux", &symbol_conf.ignore_vmlinux,
> > > >                      "don't load vmlinux even if found"),
> > > > +	OPT_BOOLEAN(0, "debuginfod", &symbol_conf.debuginfod,
> > > > +                    "fetch debuginfo keyed by build ID from the debuginfod servers, on by default, use --no-debuginfod to turn off"),

> > > I'm not sure what would be the good default.  But with this, it can slow
> > > down the process especially when the binary is not in the debuginfod.

> > That is why it allows the user to press 's' to skip it or 'd' to do a
> > one-time only disablement of this feature.

> > This is similar to gdb, that at session start asks if the debuginfo
> > files for the binary and its libraries should be downloaded, well, a bit
> > better because it allows the user to completely disable this at first
> > sight by pressing 'd'.

> > It also already honours configs that disable the ~/.debug cache.

> Oh.. I overlooked the details.  But then it'd be nice to separate the
> logic for the user interaction from the debuginfo fetching.

I will do that tomorrow, as well as have it not just in --stdio, but
also in the TUI.

I need to be more concise and granular, sorry about that.

- Arnaldo