Re: [PATCH net-next v5 2/4] net: mana: give each HWC message slot its own completion state

From: Jakub Kicinski

Date: Mon Sep 14 2026 - 20:51:03 EST


On Mon, 7 Sep 2026 20:51:56 -0700 Long Li wrote:
> + status = ctx->status_code;
> + spin_unlock_irqrestore(&ctx->lock, flags);
> + hwc_ctx_put(hwc, ctx);
> +
> +check_status:
> + if (err)
> + goto done;
>
> - if (ctx->status_code && ctx->status_code != GDMA_STATUS_MORE_ENTRIES) {
> - if (ctx->status_code == GDMA_STATUS_CMD_UNSUPPORTED) {
> + if (status && status != GDMA_STATUS_MORE_ENTRIES) {

Please don't use goto to jump around functions.
This code needs to be refactored.
So does patch 4 at a glance.