Re: [PATCH v9 5/9] thermal/drivers/exynos: Remove redundant base_second register resource
From: Anand Moon
Date: Tue Sep 15 2026 - 00:43:58 EST
Hi Krzysztof,
Thanks for your review comments.
On Mon, 14 Sept 2026 at 12:36, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 13/09/2026 16:58, Anand Moon wrote:
> > The Exynos5420 TRIMINFO register can be accessed through the main TMU
> > register space, so a separate register mapping is not required.
>
> No, the address is misplaced. You completely ignored entire point for
> second base, without any arguments, any data, anything, and just drop it
> completely.
>
> NAK
I removed base_second based on the observation that it is only used to access
EXYNOS_TMU_REG_TRIMINFO for the CPU and GPU instances.
It is not used for any other TMU register accesses in the driver.
>
> Best regards,
> Krzysztof
Thanks
-Anand