Re: [PATCH v9 8/9] thermal/drivers/exynos: Add missing drvdata assignment in Exynos TMU probe

From: Anand Moon

Date: Tue Sep 15 2026 - 00:45:02 EST


Hi Krzysztof,

Thanks for your review comments.
On Mon, 14 Sept 2026 at 12:31, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 13/09/2026 16:58, Anand Moon wrote:
> > Add dev_set_drvdata(&pdev->dev, data) early in the probe function,
> > ensuring that the driver data is properly registered and accessible
> > throughout the lifecycle of the device.
> >
> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
>
> This is somehow confusing or completely incorrect code.
>
> Either this was needed by the driver or not. If it was, then why no bug
> is being described? If this was not needed, then you are doing no-op
> changes.
>
I was looking into other SoCs that use this while debugging the
device-tree mapping issue,
so I initially tried adding it. If it is not required, I will drop this change.
>
>
> Best regards,
> Krzysztof

Thanks
-Anand