Re: [PATCH] locking/osq_lock: Ensure proper locking semantics for osq_lock/osq_unlock()
From: Peter Zijlstra
Date: Tue Sep 15 2026 - 01:22:56 EST
On Mon, Sep 14, 2026 at 10:30:12PM -0400, Waiman Long wrote:
> On 9/14/26 7:22 AM, Peter Zijlstra wrote:
> > This doesn't make sense. You cannot argue that the code is correct as is
> > and still add Fixes.
>
> That is true. I added this paragraph to show that it is not a serious bug,
> but I still think it is better to fix it or we have to explicitly say that
> it is not a real lock in term of how it can be used. I have taken it out to
> avoid confusion.
"It is not a real lock" will do. It has always been meant as a optimistic
spin queue -- very much not a lock.