Re: [PATCH] usb: chipidea: tegra: disable runtime PM on resume failure

[Peter Chen]

On 26-09-13 00:10:33, Myeonghun Pak wrote:
> tegra_usb_probe() enables runtime PM before resuming the device. If
> pm_runtime_resume_and_get() fails, probe returns without disabling runtime
> PM. The later error paths reach pm_runtime_force_suspend(), but this early
> return bypasses that cleanup.
> 
> Disable runtime PM before returning the resume error. Do not use the
> fail_power_off path: the failed resume did not retain a usage reference,
> so its pm_runtime_put_sync_suspend() would be unbalanced.
> 
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
> 
> Fixes: 8b85e11c1a7a ("usb: chipidea: tegra: Add runtime PM and OPP support")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: OpenAI:GPT-5.6
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>

Acked-by: Peter Chen <peter.chen@xxxxxxxxxx>

Peter
> ---
>  drivers/usb/chipidea/ci_hdrc_tegra.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> index 372788f0f..26225b034 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -306,8 +306,10 @@ static int tegra_usb_probe(struct platform_device *pdev)
>  
>  	pm_runtime_enable(&pdev->dev);
>  	err = pm_runtime_resume_and_get(&pdev->dev);
> -	if (err)
> +	if (err) {
> +		pm_runtime_disable(&pdev->dev);
>  		return err;
> +	}
>  
>  	if (device_property_present(&pdev->dev, "nvidia,needs-double-reset"))
>  		usb->needs_double_reset = true;

-- 

Thanks,
Peter Chen