Re: [PATCH v3] xfs: don't hold buffer locks across sync transaction commit in xfs_sync_sb_buf

From: Christoph Hellwig

Date: Tue Sep 15 2026 - 02:41:55 EST


On Mon, Sep 14, 2026 at 09:31:05PM -0700, Darrick J. Wong wrote:
> >
> > Alternatively, since xfs_ioc_setlabel() is currently the only caller
> > and it's kernel-only, we could just move xfs_sync_sb_buf() out of
> > libxfs into xfs_ioctl.c.
>
> Probably safer to do that, since there's no other user of that function,
> and none in userspace.

Yeah, I was going to suggest to move it out of libxfs as well.
Either xfs_ioctl.c or something like xfs_mount.c if we think it will
be reused elsewhere in the near future.