Re: [v2 03/21] kallsyms: output binary data to speed output and kallsyms assembly

From: Markus Elfring

Date: Tue Sep 15 2026 - 03:16:36 EST


>> I suggest to avoid return value ignorance a bit more.
>> https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standard/rules/error-handling-err/err33-c/
>> https://cwe.mitre.org/data/definitions/252.html
>
> And I suggest you do some real coding...
> The error is sticky and can be checked using ferror().

Are there further warnings to reconsider also according to unchecked and unused return values?


> Code that looks at the return value from fprintf() fwrite() etc is very
> often broken because the only time they can actual fail is when the
> buffer is flushed during close.

Is this a special implementation detail?


> Adding error checks to every call just make the code unreadable.
Some developers got used to corresponding programming possibilities.
Interests might grow also for aspect-oriented software development,
doesn't it?

Regards,
Markus