[PATCH v2] drm/imagination: Remove duplicated CCB control initialisation

From: Alexandru Dadu

Date: Tue Sep 15 2026 - 03:38:02 EST


From: Alessio Belle <alessio.belle@xxxxxxxxxx>

The same is already done by the ccb_ctrl_init() callback.

Signed-off-by: Alessio Belle <alessio.belle@xxxxxxxxxx>
Reviewed-by: Brajesh Gupta <brajesh.gupta@xxxxxxxxxx>
Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
---
Changes in v2:
- Added Signed-off-by and Reviewed-by lines in the commit message.
- Link to v1: https://patch.msgid.link/20260810-b4-upstream-remove-duplicate-ccb-control-init-v1-1-4ea79b116b40@xxxxxxxxxx

To: Alessio Belle <alessio.belle@xxxxxxxxxx>
To: Luigi Santivetti <luigi.santivetti@xxxxxxxxxx>
To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
To: Maxime Ripard <mripard@xxxxxxxxxx>
To: Thomas Zimmermann <tzimmermann@xxxxxxx>
To: David Airlie <airlied@xxxxxxxxx>
To: Simona Vetter <simona@xxxxxxxx>
Cc: imagination@xxxxxxxxxxxxxxxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
---
drivers/gpu/drm/imagination/pvr_ccb.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_ccb.c b/drivers/gpu/drm/imagination/pvr_ccb.c
index 4accf18e2341..48672a86ca2f 100644
--- a/drivers/gpu/drm/imagination/pvr_ccb.c
+++ b/drivers/gpu/drm/imagination/pvr_ccb.c
@@ -82,11 +82,6 @@ pvr_ccb_init(struct pvr_device *pvr_dev, struct pvr_ccb *pvr_ccb,
pvr_fw_object_get_fw_addr(pvr_ccb->ctrl_obj, &pvr_ccb->ctrl_fw_addr);
pvr_fw_object_get_fw_addr(pvr_ccb->ccb_obj, &pvr_ccb->ccb_fw_addr);

- WRITE_ONCE(pvr_ccb->ctrl->write_offset, 0);
- WRITE_ONCE(pvr_ccb->ctrl->read_offset, 0);
- WRITE_ONCE(pvr_ccb->ctrl->wrap_mask, num_cmds - 1);
- WRITE_ONCE(pvr_ccb->ctrl->cmd_size, cmd_size);
-
return 0;

err_free_ctrl:

---
base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
change-id: 20260810-b4-upstream-remove-duplicate-ccb-control-init-ed10e641d81b

Best regards,
--
Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>