[PATCH v2 1/2] Bluetooth: btnxpuart: Simplify nxp_recv_acl_pkt() by hci_acl_handle()

[Neeraj Kale]

Hi Zijun,

Thank you for the patch. The fix looks good to me.

Reviewed-by: Neeraj Sanjay Kale neeraj.sanjaykale@xxxxxxx

Thanks,
Neeraj

> Simplify nxp_recv_acl_pkt() by using hci_acl_handle() instead of:
>
> __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
> ... (handle & 0x0FFF) ...
>
> Signed-off-by: Zijun Hu <zijun.hu@xxxxxxxxxxxxxxxx>
> ---
>  drivers/bluetooth/btnxpuart.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
> index f2bbe6e462aa..69e897444112 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -1400,20 +1400,18 @@ static int nxp_process_fw_dump(struct hci_dev
> *hdev, struct sk_buff *skb)
>
>  free_skb:
>         kfree_skb(skb);
>         return 0;
>  }
>
>  static int nxp_recv_acl_pkt(struct hci_dev *hdev, struct sk_buff *skb)  {
> -       __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
> -
>         /* FW dump chunks are ACL packets with conn handle 0xfff */
> -       if ((handle & 0x0FFF) == 0xFFF)
> +       if (hci_acl_handle(skb) == 0xFFF)
>                 return nxp_process_fw_dump(hdev, skb);
>         else
>                 return hci_recv_frame(hdev, skb);  }
>
>  static int nxp_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)  {
>         union nxp_set_bd_addr_payload pcmd;
>
> --
> 2.34.1


NXP Confidential