Re: [PATCH v3 1/3] scsi: ufs: dt-bindings: starfive: Add UFS Host Controller for JHB100 soc

[Minda Chen]

> 
> On Fri, Sep 11, 2026 at 06:23:57PM +0800, Minda Chen wrote:
> > Add devicetree document for UFS Host Controller StarFive JHB100 SoC.
> > The UFS controller is based on the Synopsys DesignWare UFS controller.
> >
> > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/ufs/starfive,jhb100-ufs.yaml     | 71 +++++++++++++++++++
> >  MAINTAINERS                                   |  5 ++
> >  2 files changed, 76 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/ufs/starfive,jhb100-ufs.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/ufs/starfive,jhb100-ufs.yaml
> > b/Documentation/devicetree/bindings/ufs/starfive,jhb100-ufs.yaml
> > new file mode 100644
> > index 000000000000..a65cc9455a85
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ufs/starfive,jhb100-ufs.yaml
> > @@ -0,0 +1,71 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/ufs/starfive,jhb100-ufs.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Starfive Universal Flash Storage (UFS) Controller
> > +
> > +maintainers:
> > +  - Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: ufs-common.yaml
> > +
> > +properties:
> > +  compatible:
> > +    const: starfive,jhb100-ufs
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: main
> > +
> > +  resets:
> > +    items:
> > +      - description: UFS main reset
> > +      - description: UFS PHY reset
> > +
> > +  reset-names:
> > +    items:
> > +      - const: main
> > +      - const: phy
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  starfive,syscon:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description:
> > +      The phandle to System Register Controller syscon node.
> 
> This should probably say "that contains xyz" where xyz is the thing that you need
> up access in your driver. The jhb100 has a large number of syscons, so knowing
> what to look for here is essential! (although realistically you'll set this in
> jhb100.dtsi and noone will have to look it up themselves)
> 
Okay I will add syscon function to description， Thanks!

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> pw-bot: changes-requested
> 
> Thanks,
> Conor.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - resets
> > +  - reset-names
> > +  - interrupts
> > +  - starfive,syscon
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    ufs@11b10000 {
> > +        compatible = "starfive,jhb100-ufs";
> > +        reg = <0x11b10000 0x20000>;
> > +        interrupts = <105>;
> > +        clocks = <&syscrg 4>;
> > +        clock-names = "main";
> > +        resets = <&syscrg 10>,
> > +                 <&syscrg 7>;
> > +        reset-names = "main", "phy";
> > +        starfive,syscon = <&syscon>;
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > fc320b373656..10b0d0839ca4 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -28095,6 +28095,11 @@ L:	linux-scsi@xxxxxxxxxxxxxxx
> >  S:	Maintained
> >  F:	drivers/ufs/host/ufs-renesas.c
> >
> > +UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER STARFIVE
> > +M:	Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/ufs/starfive,jhb100-ufs.yaml
> > +
> >  UNIWILL LAPTOP DRIVER
> >  M:	Armin Wolf <W_Armin@xxxxxx>
> >  L:	platform-driver-x86@xxxxxxxxxxxxxxx
> > --
> > 2.17.1
> >