Re: [PATCH 1/8] media: qcom: camss: take the link frequency from the CSI-2 transmitter

[Hitesh Patel]

> Its redundant to pass csiphy->camss and &csiphy->subdev.entity
> Just pass struct camss_csiphy *csiphy once and then extract the pointers
> you need in the routine.

The same helper is called from the CSID as well, so a csiphy argument
would not fit both callers. The camss pointer is reachable from the
entity itself though: container_of(entity->graph_obj.mdev, struct camss,
media_dev). I will use that in v2 and drop the extra parameter, which
also leaves the callers untouched. Does that work for you?

> This seems fine. I wonder how it works with the TPG, probably fine,
> needs testing.

With the CSID TPG there is no link on the CSID sink pad, so the walk
returns NULL and camss_get_link_freq() returns -ENODEV, exactly as
camss_find_sensor_pad() did before. I will run the TPG on RB3 Gen2
before sending v2 and mention the result in the cover letter.

> Please fix up that clause a bit so its not spralling multi-line

Will do.

Thanks for the review,
Hitesh