Re: [PATCH v2] docs: kconfig: fix shell function syntax in caveats

[Nicolas Schier]

On Mon, Sep 07, 2026 at 01:37:37PM +0300, Erkan Erdem wrote:
> Kconfig separates a function name from its arguments with a comma, but
> the caveats section uses Make-style whitespace in its shell calls.
> These expressions expand as undefined variables rather than invoking
> the shell function, so the supposedly working CC_HAS_ENDIAN_FLAG
> example fails to parse.
> 
> Add the missing commas to the shell calls in this section. Keep the
> Make examples unchanged.
> 
> Fixes: 316d55d55f49 ("Documentation: kconfig: document a new Kconfig macro language")
> Assisted-by: LLM
> Signed-off-by: Erkan Erdem <hexvalid@xxxxxxxxx>
> ---
> 
> Changes in v2, addressing Julian Braha's review:
> - Remove whitespace after the comma in the three remaining shell calls.
> 
> v1: https://lore.kernel.org/all/20260905124045.42713-1-hexvalid@xxxxxxxxx/
> 
> The issue, patch and changelog were prepared with an AI coding assistant.
> The assistant also prepared the v2 revision and ran the checks below.
> 
> Validation:
> - Re-ran the documented working CC_HAS_ENDIAN_FLAG example using the
>   Kconfig conf tool built with Clang on macOS. With a test helper returning
>   y for either endian flag, the original example fails to parse; v2
>   executes both probes and sets CC_HAS_ENDIAN_FLAG=y for both endiannesses.
> - Rebuilt the changed page alone with Sphinx, treating warnings as errors.
> - The complete kernel documentation set and kernel were not built.
> 
>  Documentation/kbuild/kconfig-macro-language.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Thanks!  I'll queue it for kbuild-fixes, but it might be defered to v7.4 
if no other build relevant fix will pop-up.

Reviewed-by: Nicolas Schier <n.schier@xxxxxxxxx>

-- 
Nicolas